Skip to content

Fix mobile build and test failures in extra-platforms pipeline #124000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kotlarmilos merged 9 commits into from
Feb 9, 2026
Merged

Fix mobile build and test failures in extra-platforms pipeline #124000

kotlarmilos merged 9 commits into from
Feb 9, 2026
+17 −8

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Feb 4, 2026 •
edited
Loading

Description

This PR fixes several failures encountered in extra-platforms pipeline:

  • Updates ZipMergedPayloadDirectory target to use PreparePayloadDirectories instead of PrepareMergedTestPayloadDirectories, which was inlined in Remove legacy XUnitWrapper test tree infrastructure #123110. This should fix Apple mobile runtime tests
  • Includes StandaloneTestRunner markers used for Native AOT mobile tests
  • Excludes test markers for shared libraries on Android
  • Disables unreliable socket tests on Apple mobile

Native AOT builds will be fixed in #124083

Copilot AI review requested due to automatic review settings February 4, 2026 11:53
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 4, 2026
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a broken target dependency in the Apple mobile jobs that was introduced by PR #123110. That PR removed the PrepareMergedTestPayloadDirectories target and inlined its content into the PreparePayloadDirectories target, but left a reference to the old target name in the ZipMergedPayloadDirectory target.

Changes:

  • Updated ZipMergedPayloadDirectory target's AfterTargets dependency from the removed PrepareMergedTestPayloadDirectories to the existing PreparePayloadDirectories target

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 4, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos changed the title Fix target dependency for Apple mobile jobs Fix Apple mobile tests failures in extra-platforms pipeline Feb 4, 2026
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 4, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2026

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 4, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Copilot AI review requested due to automatic review settings February 5, 2026 12:19
Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 5, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 5, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings February 6, 2026 13:07
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 6, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 6, 2026

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 6, 2026
Open
Open
@kotlarmilos
Apply suggestion from @Copilot
19e4681 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 9, 2026 08:42
@kotlarmilos kotlarmilos changed the title Fix Apple mobile tests failures in extra-platforms pipeline Fix mobile build and test failures in extra-platforms pipeline Feb 9, 2026
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Feb 9, 2026

Extra platforms run with fixed tests:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1282804&view=results

@kotlarmilos kotlarmilos added os-android area-Infrastructure os-ios Apple iOS and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 9, 2026
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Feb 9, 2026
Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 9, 2026

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Feb 9, 2026
Open
@kotlarmilos kotlarmilos merged commit 3d18392 into dotnet:main Feb 9, 2026
124 of 127 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

Copilot code review Copilot Copilot left review comments

@matouskozak matouskozak matouskozak approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees

@kotlarmilos kotlarmilos

Labels

area-Infrastructure os-android os-ios Apple iOS

Projects

Runtime Infra
Status: Done

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos @MichalStrehovsky @matouskozak